test: relax min assertion in test-performance-eventloopdelay#63100
Open
marcopiraccini wants to merge 1 commit intonodejs:mainfrom
Open
test: relax min assertion in test-performance-eventloopdelay#63100marcopiraccini wants to merge 1 commit intonodejs:mainfrom
marcopiraccini wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63100 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 712 712
Lines 220512 220512
Branches 42289 42287 -2
=======================================
+ Hits 197690 197697 +7
Misses 14663 14663
+ Partials 8159 8152 -7 🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this flacky test issue: #41286
I think the test is wrong and it should check min >= 0.
monitorEventLoopDelay configures the histogram with
lowest_discernible_value= 1000 ns. hdr_min() returns the lower bound of the bucket the smallest sample landed in, and for that config the first bucket is [0, 512) ns — lower bound 0.So min === 0 just means the smallest sample fell into the first bucket.
In other words, seems to me that the assert is wrong, and
min=== 0 is legitThis PR fixes the assert.